[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: =?utf-8?q?Re=3A_Review_Request=3A_Adding_=C3=85ngstr=C3=B6m_to_KUnitConve?=
From: "John Layt" <john () layt ! net>
Date: 2011-03-23 10:32:52
Message-ID: 20110323103252.27913.79356 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100923/#review2120
-----------------------------------------------------------
Weird, could have sworn I added Angstrom a while back. Anyway, just to add=
to the "Dumb English" vote for versions without the accents and the plural=
versions, we do this with other values as well. Wikipedia mentions someth=
ing about both Unicode U+212B and Unicode U+00C5Oh being used for the symbo=
l so we'd need both as synonyms? Oh and I think we can have "A" as a synon=
ym as well provided it doesn't clash with something else (yes we English ar=
e that lazy, or at least our keyboards are :-)
- John
On March 22, 2011, 8:43 p.m., Etienne Rebetez wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100923/
> -----------------------------------------------------------
> =
> (Updated March 22, 2011, 8:43 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Summary
> -------
> =
> Hi,
> Just adding =C3=85ngstr=C3=B6m as a lenght unit to kunitcoversion. =
> I plan to integrate KUnitConversion into Kalzium. Since the lenght values=
of elements in ements.xml are stored in =C3=85ngstr=C3=B6m i need that uni=
t to.
> =
> http://en.wikipedia.org/wiki/%C3%85ngstr%C3%B6m
> =
> Etienne
> =
> =
> Diffs
> -----
> =
> kunitconversion/converter.h f52b602 =
> kunitconversion/length.cpp d734443 =
> =
> Diff: http://git.reviewboard.kde.org/r/100923/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Etienne
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100923/">http://git.reviewboard.kde.org/r/100923/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Weird, could have sworn \
I added Angstrom a while back. Anyway, just to add to the "Dumb English" \
vote for versions without the accents and the plural versions, we do this with other \
values as well. Wikipedia mentions something about both Unicode U+212B and Unicode \
U+00C5Oh being used for the symbol so we'd need both as synonyms? Oh and I think \
we can have "A" as a synonym as well provided it doesn't clash with \
something else (yes we English are that lazy, or at least our keyboards are :-)</pre> \
<br />
<p>- John</p>
<br />
<p>On March 22nd, 2011, 8:43 p.m., Etienne Rebetez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Etienne Rebetez.</div>
<p style="color: grey;"><i>Updated March 22, 2011, 8:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi, Just adding Ångström as a lenght unit to kunitcoversion.
I plan to integrate KUnitConversion into Kalzium. Since the lenght values of elements \
in ements.xml are stored in Ångström i need that unit to.
http://en.wikipedia.org/wiki/%C3%85ngstr%C3%B6m
Etienne
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kunitconversion/converter.h <span style="color: grey">(f52b602)</span></li>
<li>kunitconversion/length.cpp <span style="color: grey">(d734443)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100923/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic