--nextPart5169130.OEhnULMpJp Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 23 March 2011, Johannes Sixt wrote: > Am 3/22/2011 23:14, schrieb Parker Coates: > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/100923/ > >=20 > >=20 > > kunitconversion/length.cpp > > > 95line146> (Diff revision 1) > >=20 > > Length::Length() : UnitCategory(LengthCategory) > >=20 > > 146 > > =09 > > i18nc("unit synonyms for matching user input", > > "=C3=85ngstr=C3=B6m;=C3=85ngstrom;Angstr=C3=B6m,=C3=85"), >=20 > What is the encoding of this string? What is the encoding of the > source file? I guess this is a latin1 string; No. All of KDE's source code uses utf-8. > shouldn't you better write the string as >=20 > "\xc5ngstr\xf6m;\xc5ngstrom;Angstr\xf6m;Angstrom;\xc5" >=20 > to avoid any encoding errors? (Also, did you mean ; instead of , > before the final =C3=85?) Yes, that's definitely safer than using non-ASCII character in source=20 code. Regards, Ingo --nextPart5169130.OEhnULMpJp Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (GNU/Linux) iEYEABECAAYFAk2KR9QACgkQGnR+RTDgudh7vQCgkzMOpq6iG6298GVVsCjIrzAP ntUAoN2GALoOTsLvRqTAoIzFz/fBDdBh =AzpF -----END PGP SIGNATURE----- --nextPart5169130.OEhnULMpJp--