[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: KDateEdit moving into kdelibs
From: "David Jarvie" <djarvie () kde ! org>
Date: 2010-11-30 9:43:33
Message-ID: 20101130094333.27705.68486 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6014/#review9054
-----------------------------------------------------------
The code is based on an old version of KDateEdit - the feature in the libkd=
epim version to set a minimum and/or maximum date is missing. This needs to=
be added, or it will break things.
/trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h
<http://svn.reviewboard.kde.org/r/6014/#comment9847>
Please update my email to djarvie@kde.org (here and in other places)
- David
On 2010-11-29 22:11:34, Kevin Ottens wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6014/
> -----------------------------------------------------------
> =
> (Updated 2010-11-29 22:11:34)
> =
> =
> Review request for kdelibs and KDE PIM.
> =
> =
> Summary
> -------
> =
> For a very long time now there's been a KDateEdit widget cooking up in kd=
epim. It's in fact a popular one, and I'm aware of around half a dozen (som=
etimes modified) copies of that widget. One of the most advanced fork is in=
Skrooge ATM. During the latest KDE Hacking Session in Toulouse, I sat down=
with the Skrooge maintainer and produced a refactored version of KDateEdit=
which also cover their needs.
> =
> This patch is about introducing this widget in kdeui. It basically comes =
with three new classes:
> - KDateEdit itself;
> - KDatePickerPopup used by KDateEdit to popup a calendar picker;
> - KDateValidator used by KDateEdit to validate the input, it's made publ=
ic as some of the fixup behavior can be tuned.
> =
> Note that KDateTable already exposed a class named KDateValidator (much l=
ess advanced), so I took care of copying the extra method the former KDateV=
alidator was exposing for BC reasons.
> =
> I'm aiming for inclusion in 4.6, so a prompt review would be welcome. Tha=
nks in advance. ;-)
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/includes/CMakeLists.txt 1201925 =
> /trunk/KDE/kdelibs/includes/KDateEdit PRE-CREATION =
> /trunk/KDE/kdelibs/includes/KDatePickerPopup PRE-CREATION =
> /trunk/KDE/kdelibs/includes/KDateValidator 1201925 =
> /trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1201925 =
> /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h PRE-CREATION =
> /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.cpp PRE-CREATION =
> /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.h PRE-CREATION =
> /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.cpp PRE-CREATION =
> /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.h 1201925 =
> /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.cpp 1201925 =
> /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.h PRE-CREATION =
> /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.cpp PRE-CREATION =
> /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator_p.h PRE-CREATION =
> =
> Diff: http://svn.reviewboard.kde.org/r/6014/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Kevin
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6014/">http://svn.reviewboard.kde.org/r/6014/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code is based on an \
old version of KDateEdit - the feature in the libkdepim version to set a minimum \
and/or maximum date is missing. This needs to be added, or it will break \
things.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6014/diff/1/?file=41838#file41838line5" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">5</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> Copyright (c) 2002 David Jarvie \
<software@astrojar.org.uk></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
update my email to djarvie@kde.org (here and in other places)</pre> </div>
<br />
<p>- David</p>
<br />
<p>On November 29th, 2010, 10:11 p.m., Kevin Ottens wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and KDE PIM.</div>
<div>By Kevin Ottens.</div>
<p style="color: grey;"><i>Updated 2010-11-29 22:11:34</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For a very long time now there's been a KDateEdit widget cooking up \
in kdepim. It's in fact a popular one, and I'm aware of around half a dozen \
(sometimes modified) copies of that widget. One of the most advanced fork is in \
Skrooge ATM. During the latest KDE Hacking Session in Toulouse, I sat down with the \
Skrooge maintainer and produced a refactored version of KDateEdit which also cover \
their needs.
This patch is about introducing this widget in kdeui. It basically comes with three \
new classes:
- KDateEdit itself;
- KDatePickerPopup used by KDateEdit to popup a calendar picker;
- KDateValidator used by KDateEdit to validate the input, it's made public as \
some of the fixup behavior can be tuned.
Note that KDateTable already exposed a class named KDateValidator (much less \
advanced), so I took care of copying the extra method the former KDateValidator was \
exposing for BC reasons.
I'm aiming for inclusion in 4.6, so a prompt review would be welcome. Thanks in \
advance. ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/includes/CMakeLists.txt <span style="color: \
grey">(1201925)</span></li>
<li>/trunk/KDE/kdelibs/includes/KDateEdit <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/KDatePickerPopup <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/KDateValidator <span style="color: \
grey">(1201925)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/CMakeLists.txt <span style="color: \
grey">(1201925)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdateedit.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatetable.h <span style="color: \
grey">(1201925)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatetable.cpp <span style="color: \
grey">(1201925)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6014/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic