The code is based on an old version of KDateEdit - the feature in the libkdepim version to set a minimum and/or maximum date is missing. This needs to be added, or it will break things.
Please update my email to djarvie@kde.org (here and in other places)
- David
On November 29th, 2010, 10:11 p.m., Kevin Ottens wrote:
Review request for kdelibs and KDE PIM.
By Kevin Ottens.
Updated 2010-11-29 22:11:34
Description
For a very long time now there's been a KDateEdit widget cooking up in kdepim. It's in fact a popular one, and I'm aware of around half a dozen (sometimes modified) copies of that widget. One of the most advanced fork is in Skrooge ATM. During the latest KDE Hacking Session in Toulouse, I sat down with the Skrooge maintainer and produced a refactored version of KDateEdit which also cover their needs.
This patch is about introducing this widget in kdeui. It basically comes with three new classes:
- KDateEdit itself;
- KDatePickerPopup used by KDateEdit to popup a calendar picker;
- KDateValidator used by KDateEdit to validate the input, it's made public as some of the fixup behavior can be tuned.
Note that KDateTable already exposed a class named KDateValidator (much less advanced), so I took care of copying the extra method the former KDateValidator was exposing for BC reasons.
I'm aiming for inclusion in 4.6, so a prompt review would be welcome. Thanks in advance. ;-)
|
Diffs
- /trunk/KDE/kdelibs/includes/CMakeLists.txt (1201925)
- /trunk/KDE/kdelibs/includes/KDateEdit (PRE-CREATION)
- /trunk/KDE/kdelibs/includes/KDatePickerPopup (PRE-CREATION)
- /trunk/KDE/kdelibs/includes/KDateValidator (1201925)
- /trunk/KDE/kdelibs/kdeui/CMakeLists.txt (1201925)
- /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h (PRE-CREATION)
- /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.cpp (PRE-CREATION)
- /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.h (PRE-CREATION)
- /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.cpp (PRE-CREATION)
- /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.h (1201925)
- /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.cpp (1201925)
- /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.h (PRE-CREATION)
- /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.cpp (PRE-CREATION)
- /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator_p.h (PRE-CREATION)
View Diff
|