From kde-core-devel Tue Nov 30 09:43:33 2010 From: "David Jarvie" Date: Tue, 30 Nov 2010 09:43:33 +0000 To: kde-core-devel Subject: Re: Review Request: KDateEdit moving into kdelibs Message-Id: <20101130094333.27705.68486 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=129111029028528 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6679542251447565701==" --===============6679542251447565701== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6014/#review9054 ----------------------------------------------------------- The code is based on an old version of KDateEdit - the feature in the libkd= epim version to set a minimum and/or maximum date is missing. This needs to= be added, or it will break things. /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h Please update my email to djarvie@kde.org (here and in other places) - David On 2010-11-29 22:11:34, Kevin Ottens wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6014/ > ----------------------------------------------------------- > = > (Updated 2010-11-29 22:11:34) > = > = > Review request for kdelibs and KDE PIM. > = > = > Summary > ------- > = > For a very long time now there's been a KDateEdit widget cooking up in kd= epim. It's in fact a popular one, and I'm aware of around half a dozen (som= etimes modified) copies of that widget. One of the most advanced fork is in= Skrooge ATM. During the latest KDE Hacking Session in Toulouse, I sat down= with the Skrooge maintainer and produced a refactored version of KDateEdit= which also cover their needs. > = > This patch is about introducing this widget in kdeui. It basically comes = with three new classes: > - KDateEdit itself; > - KDatePickerPopup used by KDateEdit to popup a calendar picker; > - KDateValidator used by KDateEdit to validate the input, it's made publ= ic as some of the fixup behavior can be tuned. > = > Note that KDateTable already exposed a class named KDateValidator (much l= ess advanced), so I took care of copying the extra method the former KDateV= alidator was exposing for BC reasons. > = > I'm aiming for inclusion in 4.6, so a prompt review would be welcome. Tha= nks in advance. ;-) > = > = > Diffs > ----- > = > /trunk/KDE/kdelibs/includes/CMakeLists.txt 1201925 = > /trunk/KDE/kdelibs/includes/KDateEdit PRE-CREATION = > /trunk/KDE/kdelibs/includes/KDatePickerPopup PRE-CREATION = > /trunk/KDE/kdelibs/includes/KDateValidator 1201925 = > /trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1201925 = > /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h PRE-CREATION = > /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.cpp PRE-CREATION = > /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.h PRE-CREATION = > /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.cpp PRE-CREATION = > /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.h 1201925 = > /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.cpp 1201925 = > /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.h PRE-CREATION = > /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.cpp PRE-CREATION = > /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator_p.h PRE-CREATION = > = > Diff: http://svn.reviewboard.kde.org/r/6014/diff > = > = > Testing > ------- > = > = > Thanks, > = > Kevin > = > --===============6679542251447565701== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6014/

The code i=
s based on an old version of KDateEdit - the feature in the libkdepim versi=
on to set a minimum and/or maximum date is missing. This needs to be added,=
 or it will break things.

= =
/trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h (Diff revision 1)
5
  Copyright (c) 2002 David =
Jarvie <software@astrojar.org.uk>
Please update my email to djarvie@kde.org (here and in other places)=

- David


On November 29th, 2010, 10:11 p.m., Kevin Ottens wrote:

Review request for kdelibs and KDE PIM.
By Kevin Ottens.

Updated 2010-11-29 22:11:34

Descripti= on

For a very long time now there's been a KDateEdit widget=
 cooking up in kdepim. It's in fact a popular one, and I'm aware of=
 around half a dozen (sometimes modified) copies of that widget. One of the=
 most advanced fork is in Skrooge ATM. During the latest KDE Hacking Sessio=
n in Toulouse, I sat down with the Skrooge maintainer and produced a refact=
ored version of KDateEdit which also cover their needs.

This patch is about introducing this widget in kdeui. It basically comes wi=
th three new classes:
 - KDateEdit itself;
 - KDatePickerPopup used by KDateEdit to popup a calendar picker;
 - KDateValidator used by KDateEdit to validate the input, it's made pu=
blic as some of the fixup behavior can be tuned.

Note that KDateTable already exposed a class named KDateValidator (much les=
s advanced), so I took care of copying the extra method the former KDateVal=
idator was exposing for BC reasons.

I'm aiming for inclusion in 4.6, so a prompt review would be welcome. T=
hanks in advance. ;-)

Diffs=

  • /trunk/KDE/kdelibs/includes/CMakeLists.txt (1201925)
  • /trunk/KDE/kdelibs/includes/KDateEdit (PRE= -CREATION)
  • /trunk/KDE/kdelibs/includes/KDatePickerPopup (PRE-CREATION)
  • /trunk/KDE/kdelibs/includes/KDateValidator (1201925)
  • /trunk/KDE/kdelibs/kdeui/CMakeLists.txt (1= 201925)
  • /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h (PRE-CREATION)
  • /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.cpp (PRE-CREATION)
  • /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.h (PRE-CREATION)
  • /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.cpp (PRE-CREATION)
  • /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.h (1201925)
  • /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.cpp (1201925)
  • /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.h (PRE-CREATION)
  • /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.cpp (PRE-CREATION)
  • /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator_p.h (PRE-CREATION)

View Diff

--===============6679542251447565701==--