'Re: Review Request: Adds method to KBookmarkManager disable showing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Adds method to KBookmarkManager disable showing
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2010-11-29 0:08:21
Message-ID: 20101129000821.15575.72375 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6004/#review9034
-----------------------------------------------------------


Why did you change the if/else logic? Also you added another kError when th=
ere was an existing one already.

Also as commented on IRC maybe it would make sense to emit a signal to warn=
 whoever might be interested that an error happened

- Albert


On 2010-11-28 21:00:30, Matthias Fuchs wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6004/
> -----------------------------------------------------------
> =

> (Updated 2010-11-28 21:00:30)
> =

> =

> Review request for kdelibs and David Faure.
> =

> =

> Summary
> -------
> =

> Adds method to KBookmarkManager disable showing dialogs on errors.
> This way it is possible to deactivate those messages if KBoomarkManager i=
s not run in the gui thread.
> BUG:207592
> =

> =

> Diffs
> -----
> =

>   /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h 1201809 =

>   /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc 1201809 =

> =

> Diff: http://svn.reviewboard.kde.org/r/6004/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Matthias
> =

>


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6004/">http://svn.reviewboard.kde.org/r/6004/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why did you change the \
if/else logic? Also you added another kError when there was an existing one already.

Also as commented on IRC maybe it would make sense to emit a signal to warn whoever \
might be interested that an error happened</pre>  <br />







<p>- Albert</p>


<br />
<p>On November 28th, 2010, 9 p.m., Matthias Fuchs wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and David Faure.</div>
<div>By Matthias Fuchs.</div>


<p style="color: grey;"><i>Updated 2010-11-28 21:00:30</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds method to KBookmarkManager disable showing dialogs on errors. This \
way it is possible to deactivate those messages if KBoomarkManager is not run in the \
gui thread. BUG:207592</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h <span style="color: \
grey">(1201809)</span></li>

 <li>/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc <span style="color: \
grey">(1201809)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6004/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic