From kde-core-devel Mon Nov 29 00:08:21 2010 From: "Albert Astals Cid" Date: Mon, 29 Nov 2010 00:08:21 +0000 To: kde-core-devel Subject: Re: Review Request: Adds method to KBookmarkManager disable showing Message-Id: <20101129000821.15575.72375 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=129098936215268 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2869008736294962449==" --===============2869008736294962449== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/#review9034 ----------------------------------------------------------- Why did you change the if/else logic? Also you added another kError when th= ere was an existing one already. Also as commented on IRC maybe it would make sense to emit a signal to warn= whoever might be interested that an error happened - Albert On 2010-11-28 21:00:30, Matthias Fuchs wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6004/ > ----------------------------------------------------------- > = > (Updated 2010-11-28 21:00:30) > = > = > Review request for kdelibs and David Faure. > = > = > Summary > ------- > = > Adds method to KBookmarkManager disable showing dialogs on errors. > This way it is possible to deactivate those messages if KBoomarkManager i= s not run in the gui thread. > BUG:207592 > = > = > Diffs > ----- > = > /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h 1201809 = > /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc 1201809 = > = > Diff: http://svn.reviewboard.kde.org/r/6004/diff > = > = > Testing > ------- > = > = > Thanks, > = > Matthias > = > --===============2869008736294962449== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6004/

Why did yo=
u change the if/else logic? Also you added another kError when there was an=
 existing one already.

Also as commented on IRC maybe it would make sense to emit a signal to warn=
 whoever might be interested that an error happened

- Albert

On November 28th, 2010, 9 p.m., Matthias Fuchs wrote:

Review request for kdelibs and David Faure.

By Matthias Fuchs.

Updated 2010-11-28 21:00:30

Descripti= on

Adds method to KBookmarkManager disable showing dialogs on e=
rrors.
This way it is possible to deactivate those messages if KBoomarkManager is =
not run in the gui thread.
BUG:207592

Diffs=

/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h (1201809)
/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc (1201809)

View Diff

--===============2869008736294962449==--