This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/

Why did you change the if/else logic? Also you added another kError when there was an existing one already.

Also as commented on IRC maybe it would make sense to emit a signal to warn whoever might be interested that an error happened

- Albert

On November 28th, 2010, 9 p.m., Matthias Fuchs wrote:

Review request for kdelibs and David Faure.

By Matthias Fuchs.

Updated 2010-11-28 21:00:30

Description

Adds method to KBookmarkManager disable showing dialogs on errors.
This way it is possible to deactivate those messages if KBoomarkManager is not run in the gui thread.
BUG:207592

Diffs

/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h (1201809)
/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc (1201809)

View Diff