[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Move from KTabWidget to KTabBar tab switching by
From: "David Faure" <faure () kde ! org>
Date: 2010-09-03 10:00:09
Message-ID: 20100903100009.28102.71192 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5184/#review7378
-----------------------------------------------------------
Ship it!
Well, I still don't understand how the setCurrentIndex could fail, the comment only \
says "it hasn't moved yet" (?), but other than that, this looks fine, please commit.
- David
On 2010-09-03 02:16:56, David Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5184/
> -----------------------------------------------------------
>
> (Updated 2010-09-03 02:16:56)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> KTabWidget implements tab switching as response to mouse wheel events. This makes \
> applications like Rekonq, that use a KTabBar instead, do nothing when the wheel is \
> scrolled.
> The proposed patch moves the behaviour implementation from KTabWidget to
> KTabBar, disables and disconnects the relevant signal in KTabBar/KTabWidget.
>
> Note that QTabBar in Qt already implements this with a small difference: it
> does not wrap around the extreme tabs. That is, it will not go from the last to
> the first tab and viceversa.
>
>
> This addresses bug 248962.
> https://bugs.kde.org/show_bug.cgi?id=248962
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdeui/widgets/ktabbar.cpp 1170425
> /trunk/KDE/kdelibs/kdeui/widgets/ktabwidget.cpp 1170425
>
> Diff: http://svn.reviewboard.kde.org/r/5184/diff
>
>
> Testing
> -------
>
> Rekonq works as expected.
> KTabWidget users, such as Konqueror and Konsole work as well.
>
>
> Thanks,
>
> David
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5184/">http://svn.reviewboard.kde.org/r/5184/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I still don't \
understand how the setCurrentIndex could fail, the comment only says "it \
hasn't moved yet" (?), but other than that, this looks fine, please \
commit.</pre> <br />
<p>- David</p>
<br />
<p>On September 3rd, 2010, 2:16 a.m., David Palacio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By David Palacio.</div>
<p style="color: grey;"><i>Updated 2010-09-03 02:16:56</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KTabWidget implements tab switching as response to mouse wheel events. \
This makes applications like Rekonq, that use a KTabBar instead, do nothing when the \
wheel is scrolled.
The proposed patch moves the behaviour implementation from KTabWidget to
KTabBar, disables and disconnects the relevant signal in KTabBar/KTabWidget.
Note that QTabBar in Qt already implements this with a small difference: it
does not wrap around the extreme tabs. That is, it will not go from the last to
the first tab and viceversa.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rekonq works as expected. KTabWidget users, such as Konqueror and \
Konsole work as well.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=248962">248962</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdeui/widgets/ktabbar.cpp <span style="color: \
grey">(1170425)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/ktabwidget.cpp <span style="color: \
grey">(1170425)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5184/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic