[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix KArchiveFile::copyTo() for large files
From:       Gökçen_Eraslan <gokcen () pardus ! org ! tr>
Date:       2010-09-03 11:40:33
Message-ID: 201009031440.34228.gokcen () pardus ! org ! tr
[Download RAW message or body]


17 Ağustos 2010 Salı günü (saat 23:36:24) David Faure şunları yazmıştı:
> Ship it!
> 
> 
> Thanks, please commit.
> 
> - David

This change has broken extracting zip files via KZip class. For example try to 
install attached plasmoid using:

plasmapkg -i 118636-day-and-night.plasmoid

You will see:

"KConfigIni: In file /tmp/kde-gokcen/plasmapkgeu4DbG/metadata.desktop, line 1: 
" Invalid entry (missing ']') ·                                                       \
 "KConfigIni: In file /tmp/kde-gokcen/plasmapkgeu4DbG/metadata.desktop, line 2: 
" Invalid entry (missing '=') ·                                                       \
 "KConfigIni: In file /tmp/kde-gokcen/plasmapkgeu4DbG/metadata.desktop, line 3: 
" Invalid entry (missing '=') ·                                                       \
 "KConfigIni: In file /tmp/kde-gokcen/plasmapkgeu4DbG/metadata.desktop, line 4: 
" Invalid entry (missing ']') ·                                                       \
 "KConfigIni: In file /tmp/kde-gokcen/plasmapkgeu4DbG/metadata.desktop, line 5: 
" Invalid entry (missing ']') ·                                                       \
 plasmapkg(7657)/libplasma Plasma::Package::installPackage: Package plugin name 
not specified ·                                                                       \


since metadata.desktop is garbage. Garbage metadata.desktop is also attached. 
When I recompile 4.5.1 without this commit I can normally install this 
plasmoid via plasmapkg.

-- 
Gökçen Eraslan


["118636-day-and-night.plasmoid" (application/x-plasma)]
["metadata.desktop" (application/x-desktop)]

[prev in list] [next in list] [prev in thread] [next in thread]