From kde-core-devel Fri Sep 03 10:00:09 2010 From: "David Faure" Date: Fri, 03 Sep 2010 10:00:09 +0000 To: kde-core-devel Subject: Re: Review Request: Move from KTabWidget to KTabBar tab switching by Message-Id: <20100903100009.28102.71192 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=128350807730189 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8657286229491001835==" --===============8657286229491001835== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5184/#review7378 ----------------------------------------------------------- Ship it! Well, I still don't understand how the setCurrentIndex could fail, the comm= ent only says "it hasn't moved yet" (?), but other than that, this looks fi= ne, please commit. - David On 2010-09-03 02:16:56, David Palacio wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5184/ > ----------------------------------------------------------- > = > (Updated 2010-09-03 02:16:56) > = > = > Review request for kdelibs. > = > = > Summary > ------- > = > KTabWidget implements tab switching as response to mouse wheel events. Th= is makes applications like Rekonq, that use a KTabBar instead, do nothing w= hen the wheel is scrolled. > = > The proposed patch moves the behaviour implementation from KTabWidget to > KTabBar, disables and disconnects the relevant signal in KTabBar/KTabWidg= et. > = > Note that QTabBar in Qt already implements this with a small difference: = it > does not wrap around the extreme tabs. That is, it will not go from the l= ast to > the first tab and viceversa. > = > = > This addresses bug 248962. > https://bugs.kde.org/show_bug.cgi?id=3D248962 > = > = > Diffs > ----- > = > /trunk/KDE/kdelibs/kdeui/widgets/ktabbar.cpp 1170425 = > /trunk/KDE/kdelibs/kdeui/widgets/ktabwidget.cpp 1170425 = > = > Diff: http://svn.reviewboard.kde.org/r/5184/diff > = > = > Testing > ------- > = > Rekonq works as expected. > KTabWidget users, such as Konqueror and Konsole work as well. > = > = > Thanks, > = > David > = > --===============8657286229491001835== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5184/

Ship it!

Well, I st=
ill don't understand how the setCurrentIndex could fail, the comment on=
ly says "it hasn't moved yet" (?), but other than that, this =
looks fine, please commit.

- David

On September 3rd, 2010, 2:16 a.m., David Palacio wrote:

Review request for kdelibs.

By David Palacio.

Updated 2010-09-03 02:16:56

Descripti= on

KTabWidget implements tab switching as response to mouse whe=
el events. This makes applications like Rekonq, that use a KTabBar instead,=
 do nothing when the wheel is scrolled.

The proposed patch moves the behaviour implementation from KTabWidget to
KTabBar, disables and disconnects the relevant signal in KTabBar/KTabWidget.

Note that QTabBar in Qt already implements this with a small difference: it
does not wrap around the extreme tabs. That is, it will not go from the las=
t to
the first tab and viceversa.

Testing <= /h1>

Rekonq works as expected.
KTabWidget users, such as Konqueror and Konsole work as well.

Bugs: 248962

Diffs=

/trunk/KDE/kdelibs/kdeui/widgets/ktabbar.cpp (1170425)
/trunk/KDE/kdelibs/kdeui/widgets/ktabwidget.cpp (1170425)

--===============8657286229491001835==--