[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: follow html5 unquoted attribute sintax
From: "Germain Garand" <germain () ebooksfrance ! org>
Date: 2010-01-08 1:41:05
Message-ID: 20100108014105.13395.19637 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1849/#review3606
-----------------------------------------------------------
Ship it!
It looks good to me too, thank you Jaime!
I think it may even be backported to the new branch, once in trunk.
Amusing testcase:
data:text/html,<div style=content:"Failed">Passed
Otoh, this one is still broken:
data:text/html,<div ' >Not displayed
(deduced from the testcase at 33902)
- Germain
On 2009-12-13 10:14:02, Jaime Torres wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1849/
> -----------------------------------------------------------
>
> (Updated 2009-12-13 10:14:02)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Following the html5 unquoted attribute sintaxis, and finalizing the attribute value \
> when an invalid attribute is found, the bug dissapears. I'll remove the tailing \
> spaces...
>
> This addresses bug 33902.
> https://bugs.kde.org/show_bug.cgi?id=33902
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/khtml/html/htmltokenizer.cpp 1034981
>
> Diff: http://reviewboard.kde.org/r/1849/diff
>
>
> Testing
> -------
>
> I've passed the regression test.
> There are only 5 tests that are (naturally) not OK (for HTML 5).
> * mozilla/dom/dom-html/htbl048.html ( BORDER=1"> )
> * mozilla/dom/dom-html/htbl049.html ( BORDER=1"> )
> * mozilla/htmlparser/70148.html ( <a href=foo?bar=baz&lang=foo&test1=test2> \
> = not allowed )
> * mozilla/htmlparser/bug14918.html ( color=#ffffff"> )
> * real-webpages/www.smartcvs.com/features.html ( \
> content=text/html;charset=iso-8859-1 = not allowed )
>
> Thanks,
>
> Jaime
>
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic