[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: New KColorCombo palette
From: "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date: 2010-01-08 1:12:31
Message-ID: 20100108011231.12735.83188 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2476/#review3605
-----------------------------------------------------------
Maybe ordering the colors 'light red, red, dark red, light orange, orange, brown, \
...' would be better? But maybe not, it's just a thought.
/trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp
<http://reviewboard.kde.org/r/2476/#comment2867>
I imagine most people reading the comments know what "cyan" is :-). (And that \
seems less strange than "light light blue", and two things called "light blue".) But \
it's a pretty minor nit.
- Matthew
On 2010-01-07 22:00:51, Davide Bettio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2476/
> -----------------------------------------------------------
>
> (Updated 2010-01-07 22:00:51)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> New (and nicer) KColorCombo palette with more colors.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp 1068728
>
> Diff: http://reviewboard.kde.org/r/2476/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> old palette
> http://reviewboard.kde.org/r/2476/s/290/
> new palette
> http://reviewboard.kde.org/r/2476/s/291/
>
>
> Thanks,
>
> Davide
>
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic