[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: follow html5 unquoted attribute sintax
From:       "Jaime Torres" <jtamate () gmail ! com>
Date:       2009-12-13 10:14:03
Message-ID: 20091213101403.7802.106 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1849/
-----------------------------------------------------------

(Updated 2009-12-13 10:14:02.845018)


Review request for kdelibs.


Changes
-------

passed the regression test.


Summary
-------

Following the html5 unquoted attribute sintaxis, and finalizing the attribute value \
when an invalid attribute is found, the bug dissapears. I'll remove the tailing \
spaces...


This addresses bug 33902.
    https://bugs.kde.org/show_bug.cgi?id=33902


Diffs
-----

  /trunk/KDE/kdelibs/khtml/html/htmltokenizer.cpp 1034981 

Diff: http://reviewboard.kde.org/r/1849/diff


Testing (updated)
-------

I've passed the regression test.
There are only 5 tests that are (naturally) not OK (for HTML 5).
* mozilla/dom/dom-html/htbl048.html ( BORDER=1"> )
* mozilla/dom/dom-html/htbl049.html ( BORDER=1"> )
* mozilla/htmlparser/70148.html     ( <a href=foo?bar=baz&lang=foo&amptest1=test2>  = \
                not allowed )
* mozilla/htmlparser/bug14918.html  ( color=#ffffff"> )
* real-webpages/www.smartcvs.com/features.html  ( \
content=text/html;charset=iso-8859-1  = not allowed )


Thanks,

Jaime


[prev in list] [next in list] [prev in thread] [next in thread]