[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: follow html5 unquoted attribute sintax
From:       LiuCougar <liucougar () gmail ! com>
Date:       2009-10-14 19:43:55
Message-ID: 955806780910141243i354156c3h4d337d2be9b0ba08 () mail ! gmail ! com
[Download RAW message or body]

if ( curchar <= ' ' || curchar == '>' || curchar == '\'' || curchar ==
'"' || curchar == '<' || curchar == '=' || curchar == '`' )

the first <= should be ==, no?

On Wed, Oct 14, 2009 at 12:39, Jaime Torres <jtamate@gmail.com> wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1849/
> -----------------------------------------------------------
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Following the html5 unquoted attribute sintaxis, and finalizing the attribute value \
> when an invalid attribute is found, the bug dissapears. I'll remove the tailing \
> spaces... 
> 
> This addresses bug 33902.
> https://bugs.kde.org/show_bug.cgi?id=33902
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/khtml/html/htmltokenizer.cpp 1034981
> 
> Diff: http://reviewboard.kde.org/r/1849/diff
> 
> 
> Testing
> -------
> 
> One day brwosing a lot, and I've not seen new problems.
> 
> 
> Thanks,
> 
> Jaime
> 



--
Frontend Lead, teampatent.com
生于忧患，死于安乐
"People's characters are strengthened through struggle against
difficulties; they are weakened by comfort."
- Old Chinese adage


[prev in list] [next in list] [prev in thread] [next in thread]