[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Allow translations of Qt4 style names
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2009-10-14 21:12:50
Message-ID: 20091014211250.21901.53485 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1845/
-----------------------------------------------------------

(Updated 2009-10-14 21:12:49.852957)


Review request for kdelibs.


Changes
-------

- plugin name "Mac" is actually "Macintosh"
- GTK+ only for X11


Summary
-------

Please check
* if I didn't mess up the whole i18n stuff
* if the texts are good for translation
* if we are allowed to use names such as Apple, Windows, Vista, etc. in descriptions
* if the bug is worth fixing at all :)


This addresses bug 152947.
    https://bugs.kde.org/show_bug.cgi?id=152947


Diffs (updated)
-----

  /trunk/KDE/kdebase/runtime/kstyles/CMakeLists.txt 1035269 
  /trunk/KDE/kdebase/runtime/kstyles/themes/CMakeLists.txt 1035269 
  /trunk/KDE/kdebase/runtime/kstyles/themes/qtcleanlooks.themerc PRE-CREATION 
  /trunk/KDE/kdebase/runtime/kstyles/themes/qtgtk.themerc PRE-CREATION 
  /trunk/KDE/kdebase/runtime/kstyles/themes/qtmacintosh.themerc PRE-CREATION 
  /trunk/KDE/kdebase/runtime/kstyles/themes/qtplastique.themerc PRE-CREATION 
  /trunk/KDE/kdebase/runtime/kstyles/themes/qtwindowsvista.themerc PRE-CREATION 
  /trunk/KDE/kdebase/runtime/kstyles/themes/qtwindowsxp.themerc PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1845/diff


Testing
-------

Builds, installs, and shows the descriptions in my (english) system, instead of the \
old "No description available" in systemsettings.


Thanks,

Christoph


[prev in list] [next in list] [prev in thread] [next in thread]