[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: follow html5 unquoted attribute sintax
From:       Jaime Torres <jtamate () gmail ! com>
Date:       2009-10-15 7:12:19
Message-ID: 200910150912.20891.jtamate () gmail ! com
[Download RAW message or body]


It was there in that way. And I guess it is correct, any character less that 
space I think is considered a space in HTML. 

The space characters, for the purposes of this specification, are U+0020 
SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM 
FEED (FF), and U+000D CARRIAGE RETURN (CR).

Regards.

On Wednesday 14 October 2009 21:43:55 LiuCougar wrote:
> if ( curchar <= ' ' || curchar == '>' || curchar == '\'' || curchar ==
> '"' || curchar == '<' || curchar == '=' || curchar == '`' )
> 
> the first <= should be ==, no?
> 
> On Wed, Oct 14, 2009 at 12:39, Jaime Torres <jtamate@gmail.com> wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1849/
> > -----------------------------------------------------------
> >
> > Review request for kdelibs.
> >
> >
> > Summary
> > -------
> >
> > Following the html5 unquoted attribute sintaxis, and finalizing the
> > attribute value when an invalid attribute is found, the bug dissapears.
> > I'll remove the tailing spaces...
> >
> >
> > This addresses bug 33902.
> >    https://bugs.kde.org/show_bug.cgi?id=33902
> >
> >
> > Diffs
> > -----
> >
> >  /trunk/KDE/kdelibs/khtml/html/htmltokenizer.cpp 1034981
> >
> > Diff: http://reviewboard.kde.org/r/1849/diff
> >
> >
> > Testing
> > -------
> >
> > One day brwosing a lot, and I've not seen new problems.
> >
> >
> > Thanks,
> >
> > Jaime
> 
> --
> Frontend Lead, teampatent.com
> 生于忧患,死于安乐
> "People's characters are strengthened through struggle against
> difficulties; they are weakened by comfort."
> - Old Chinese adage
> 

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic