[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Fix sanitization of dbus path in KMainWindow (take 2)
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2009-08-18 16:34:18
Message-ID: 20090818163418.14326.61990 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1353/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

As pointed out by Thomas Lübking ( \
http://permalink.gmane.org/gmane.comp.kde.devel.general/58749 ), KMainWindow attempts \
to sanitize what it will allow in the dbus path. This fixes it to only allow legal \
characters in the entire path (including the part from appName). Using \
QChar::isLetter and related allows non-ASCII, so we need our own validation function \
(this one in fact comes from qdbusutil.cpp).


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/widgets/kmainwindow.cpp 1012705 

Diff: http://reviewboard.kde.org/r/1353/diff


Testing
-------

built, ran kcalc


Thanks,

Matthew


[prev in list] [next in list] [prev in thread] [next in thread]