[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix sanitization of dbus path in KMainWindow
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2009-08-18 16:19:16
Message-ID: h6eka5$lnp$1 () ger ! gmane ! org
[Download RAW message or body]

Thomas Lübking wrote:
> Am Tuesday 18 August 2009 schrieb Thiago Macieira:
>> I've also moved the application name above the cleanup, since it needs to
>> be cleaned up too. That required checking for /.
> 
> Unfortunately the appName() handling may however lead to more trouble here:
> http://permalink.gmane.org/gmane.comp.kde.devel.general/58753
> 
> Basically you'll have to choose out of a friction between appName and the dbus 
> path (thus an inconsistency), an artificially limited appName (no more 
> "plasma-desktop") or a full break in the KMainWindow dbus path (not invoke the 
> appName at all) 

"plasma-desktop" is already invalid (as I found out). If this is 
actually the appName it should be tripping the dbus name check assert... 
if KMainWindow is in use.

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
Cannot read .sig now

[prev in list] [next in list] [prev in thread] [next in thread]