[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix sanitization of dbus path in KMainWindow
From:       Thiago Macieira <thiago () kde ! org>
Date:       2009-08-18 18:27:13
Message-ID: 200908182027.13803.thiago () kde ! org
[Download RAW message or body]


Em Terça-feira 18 Agosto 2009, às 18:34:18, você escreveu:
> As pointed out by Thomas Lübking (
>  http://permalink.gmane.org/gmane.comp.kde.devel.general/58749 ),
>  KMainWindow attempts to sanitize what it will allow in the dbus path. This
>  fixes it to only allow legal characters in the entire path (including the
>  part from appName). Using QChar::isLetter and related allows non-ASCII, so
>  we need our own validation function (this one in fact comes from
>  qdbusutil.cpp).

Patch makes sense. Ship it.

The only cosmetic change I would make is to name the function 
"isValidDBusObjectPathCharacter".

> 
> built, ran kcalc

KCalc wouldn't show the issue.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
      http://qt.nokia.com/qtdevdays2009

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]