[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix sanitization of dbus path in KMainWindow
From:       Thiago Macieira <thiago () kde ! org>
Date:       2009-08-17 19:18:15
Message-ID: 200908172118.22262.thiago () kde ! org
[Download RAW message or body]

[Attachment #2 (Text/Plain)]

Matthew Woehlke wrote:
>Thomas Lübking wrote:
>> [other stuff and a Ship It]
>
>Thanks.
>
>> b) if QChar::isLetter() wouldn't rank "_" as letter it would be
>> replace by "_" anyway
>
>As far as I know, '_' isn't isLetter()... which I have ignored for this
>exact reason; yes, it is replaced, but it is replaced with itself :-).

There's a very specific list of characters that's allowed. Why not use 
that, instead of using the full unicode tables that QChar consults?

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
      http://qt.nokia.com/qtdevdays2009

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]