[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix sanitization of dbus path in KMainWindow
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2009-08-17 16:52:44
Message-ID: h6c1ss$sbs$1 () ger ! gmane ! org
[Download RAW message or body]

Thomas Lübking wrote:
> [other stuff and a Ship It]

Thanks.

> b) if QChar::isLetter() wouldn't rank "_" as letter it would be replace by "_" 
> anyway

As far as I know, '_' isn't isLetter()... which I have ignored for this 
exact reason; yes, it is replaced, but it is replaced with itself :-).

> I however fear the other thread is the much more driving one.

Agreed, it's just that everyone else hijacked the review request to 
discuss that here instead X(.

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
Some people are like Slinkies... not really good for anything, but they 
still bring a smile to your face when you push them down a flight of 
stairs. -- Gordon Wolfe

[prev in list] [next in list] [prev in thread] [next in thread]