[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix sanitization of dbus path in KMainWindow
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2009-08-17 20:13:40
Message-ID: h6cdlk$buj$1 () ger ! gmane ! org
[Download RAW message or body]

Thiago Macieira wrote:
> Matthew Woehlke wrote:
>> Thomas Lübking wrote:
>>> [other stuff and a Ship It]
>> Thanks.
>>
>>> b) if QChar::isLetter() wouldn't rank "_" as letter it would be
>>> replace by "_" anyway
>> As far as I know, '_' isn't isLetter()... which I have ignored for this
>> exact reason; yes, it is replaced, but it is replaced with itself :-).
> 
> There's a very specific list of characters that's allowed. Why not use 
> that, instead of using the full unicode tables that QChar consults?

If you'd like to "one-up" my patch, please feel free :-). Otherwise I'm 
not sure what you have in mind.

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
Some people are like Slinkies... not really good for anything, but they 
still bring a smile to your face when you push them down a flight of 
stairs. -- Gordon Wolfe

[prev in list] [next in list] [prev in thread] [next in thread]