[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [Patch] Add two new tree-based modes to KDirOperator
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2008-07-11 20:08:59
Message-ID: 200807112209.00160 () erwin ! ingo-kloecker ! de
[Download RAW message or body]


On Thursday 10 July 2008, Peter Penz wrote:
> On Thursday, 10. July 2008 16:27:40 Rafael Fernández López wrote:
> > Hi,
> >
> > > Having tested this a bit, it works fine and I can't see any
> > > problems with the code itself. Peter, Rafael what do you think?
> >
> > I have to say I haven't tested it, but the patch seems OK. This is
> > an OK from my side.
>
> +1 from my side (I also did not test it, but have checked the code)

I have no real knowledge of KDirOperator, so all I can give is a general 
advise: Adding n different modes to a single class is not really good 
design. I suggest to look into using the Strategy pattern.


Regards,
Ingo

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]