[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KFileDialog overwrite confirmation
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-07-11 20:16:31
Message-ID: 200807111416.32207.aseigo () kde ! org
[Download RAW message or body]


On Friday 11 July 2008, alessandro diaferia wrote:
> Is it just matter of making them not virtual?

as Richard noted, it seems those methods don't need to be virtual at all. so 
just make them non-virtual and things should be good. 

otherwise the patch itself looks ok (other than the indentation issues you 
already noted =).

i wonder idly if it's worth putting a //TODO KDE5: note in there about looking 
at making it the default behaviour?

> P.S. sorry for poor indentation.. Hope to clean everything if i found a way
> to not break compatibility =)

=)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]