--nextPart1586016.JG7zZzeI44 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 10 July 2008, Peter Penz wrote: > On Thursday, 10. July 2008 16:27:40 Rafael Fern=E1ndez L=F3pez wrote: > > Hi, > > > > > Having tested this a bit, it works fine and I can't see any > > > problems with the code itself. Peter, Rafael what do you think? > > > > I have to say I haven't tested it, but the patch seems OK. This is > > an OK from my side. > > +1 from my side (I also did not test it, but have checked the code) I have no real knowledge of KDirOperator, so all I can give is a general=20 advise: Adding n different modes to a single class is not really good=20 design. I suggest to look into using the Strategy pattern. Regards, Ingo --nextPart1586016.JG7zZzeI44 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBId73cGnR+RTDgudgRAhJ0AJ4uqQG5VmZHH2Hn+M1TJ8kY4HImZgCdFCLL xrhrEvyzEUbR0qK0rmwHaQk= =C4Vw -----END PGP SIGNATURE----- --nextPart1586016.JG7zZzeI44--