[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH]Re: [RFC][Fwd: Re: [RFC][Fwd: Re: Missing Oxygen icons
From:       James Richard Tyrer <tyrerj () acm ! org>
Date:       2008-06-24 11:28:51
Message-ID: 4860DA73.7020301 () acm ! org
[Download RAW message or body]

James Richard Tyrer wrote:
> James Richard Tyrer wrote:
> 
>> And here is the patch [attached].
>>
> And here is the RTL patch [attached]] which I have *not* tested.
> 
> Could someone that has a RTL language on their system, please help by 
> testing this (along with the other patch).
> 
> Single patch for both is posted here:
> 
> http://home.earthlink.net/~tyrerj/kde/KDE-4/statdard_actions0.diff
> 
> Along with a SVG only set of icons to test the patches:
> 
> http://home.earthlink.net/~tyrerj/kde/KDE-4/go-icons_KDE4.tar.bz2
> 
> Thanks.
> 

I found a bug with RTL.  The icons for FirstPage & LastPage need to be 
reversed with RTL.  So, I updated the patch to include the bug fix.

Is this OK, are there any further comments, or should I commit it?

-- 
JRT


["standard_actions1.diff" (text/plain)]

Index: kdeui/actions/kstandardaction.cpp
===================================================================
--- kdeui/actions/kstandardaction.cpp	(revision 823772)
+++ kdeui/actions/kstandardaction.cpp	(working copy)
@@ -108,16 +108,22 @@ KAction *create(StandardAction id, const
 
     if ( QApplication::isRightToLeft() ) {
       if ( id == Prior )
-        iconName = "go-next";
+        iconName = "go-next-page";
 
       if ( id == Next )
-        iconName = "go-previous";
+        iconName = "go-previous-page";
+
+      if ( id == FirstPage )
+	iconName = "go-last-page";
+
+      if ( id == LastPage )
+	iconName = "go-first-page";
 
       if ( id == DocumentBack )
-        iconName = "go-next";
+        iconName = "go-next-document";
 
       if ( id == DocumentForward )
-        iconName = "go-previous";
+        iconName = "go-previous-document";
     }
 
     QIcon icon = iconName.isEmpty() ? KIcon() : KIcon(iconName);
Index: kdeui/actions/kstandardaction_p.h
===================================================================
--- kdeui/actions/kstandardaction_p.h	(revision 823772)
+++ kdeui/actions/kstandardaction_p.h	(working copy)
@@ -80,15 +80,15 @@ static const KStandardActionInfo g_rgAct
   { Back,          KStandardShortcut::Back, "go_back", 0, 0, "go-previous" },
   { Forward,       KStandardShortcut::Forward, "go_forward", 0, 0, "go-next" },
   { Home,          KStandardShortcut::Home, "go_home", 0, 0, "go-home" },
-  { Prior,         KStandardShortcut::Prior, "go_previous", I18N_NOOP("&Previous \
                Page"), 0, "go-previous" },
-  { Next,          KStandardShortcut::Next, "go_next", I18N_NOOP("&Next Page"), 0, \
"go-next" }, +  { Prior,         KStandardShortcut::Prior, "go_previous", \
I18N_NOOP("&Previous Page"), 0, "go-previous-page" }, +  { Next,          \
KStandardShortcut::Next, "go_next", I18N_NOOP("&Next Page"), 0, "go-next-page" },  { \
Goto,          KStandardShortcut::AccelNone, "go_goto", I18N_NOOP("&Go To..."), 0, 0 \
},  { GotoPage,      KStandardShortcut::AccelNone, "go_goto_page", I18N_NOOP("&Go to \
Page..."), 0, "go-jump" },  { GotoLine,      KStandardShortcut::GotoLine, \
                "go_goto_line", I18N_NOOP("&Go to Line..."), 0, 0 },
-  { FirstPage,     KStandardShortcut::Begin, "go_first", I18N_NOOP("&First Page"), \
                0, "go-first" },
-  { LastPage,      KStandardShortcut::End, "go_last", I18N_NOOP("&Last Page"), 0, \
                "go-last" },
-  { DocumentBack,  KStandardShortcut::AccelNone, "go_document_back", \
                I18N_NOOP("&Back in the Document"), 0, "go-previous" },
-  { DocumentForward, KStandardShortcut::AccelNone, "go_document_forward", \
I18N_NOOP("&Forward in the Document"), 0, "go-next" }, +  { FirstPage,     \
KStandardShortcut::Begin, "go_first", I18N_NOOP("&First Page"), 0, "go-first-page" }, \
+  { LastPage,      KStandardShortcut::End, "go_last", I18N_NOOP("&Last Page"), 0, \
"go-last-page" }, +  { DocumentBack,  KStandardShortcut::AccelNone, \
"go_document_back", I18N_NOOP("&Back in the Document"), 0, "go-previous-document" }, \
+  { DocumentForward, KStandardShortcut::AccelNone, "go_document_forward", \
I18N_NOOP("&Forward in the Document"), 0, "go-next-document" },  
   { AddBookmark,   KStandardShortcut::AddBookmark, "bookmark_add", I18N_NOOP("&Add \
Bookmark"), 0, "bookmark-new" },  { EditBookmarks, KStandardShortcut::AccelNone, \
"bookmark_edit", I18N_NOOP("&Edit Bookmarks"), 0, "bookmarks" },



[prev in list] [next in list] [prev in thread] [next in thread]