From kde-core-devel Tue Jun 24 11:28:51 2008 From: James Richard Tyrer Date: Tue, 24 Jun 2008 11:28:51 +0000 To: kde-core-devel Subject: Re: [PATCH]Re: [RFC][Fwd: Re: [RFC][Fwd: Re: Missing Oxygen icons Message-Id: <4860DA73.7020301 () acm ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=121432461802690 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--------------080804000107050809020505" This is a multi-part message in MIME format. --------------080804000107050809020505 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit James Richard Tyrer wrote: > James Richard Tyrer wrote: > >> And here is the patch [attached]. >> > And here is the RTL patch [attached]] which I have *not* tested. > > Could someone that has a RTL language on their system, please help by > testing this (along with the other patch). > > Single patch for both is posted here: > > http://home.earthlink.net/~tyrerj/kde/KDE-4/statdard_actions0.diff > > Along with a SVG only set of icons to test the patches: > > http://home.earthlink.net/~tyrerj/kde/KDE-4/go-icons_KDE4.tar.bz2 > > Thanks. > I found a bug with RTL. The icons for FirstPage & LastPage need to be reversed with RTL. So, I updated the patch to include the bug fix. Is this OK, are there any further comments, or should I commit it? -- JRT --------------080804000107050809020505 Content-Type: text/plain; name="standard_actions1.diff" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="standard_actions1.diff" SW5kZXg6IGtkZXVpL2FjdGlvbnMva3N0YW5kYXJkYWN0aW9uLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBrZGV1aS9hY3Rpb25zL2tzdGFuZGFyZGFjdGlvbi5jcHAJKHJldmlzaW9uIDgyMzc3 MikKKysrIGtkZXVpL2FjdGlvbnMva3N0YW5kYXJkYWN0aW9uLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTA4LDE2ICsxMDgsMjIgQEAgS0FjdGlvbiAqY3JlYXRlKFN0YW5kYXJkQWN0aW9u IGlkLCBjb25zdAogCiAgICAgaWYgKCBRQXBwbGljYXRpb246OmlzUmlnaHRUb0xlZnQoKSAp IHsKICAgICAgIGlmICggaWQgPT0gUHJpb3IgKQotICAgICAgICBpY29uTmFtZSA9ICJnby1u ZXh0IjsKKyAgICAgICAgaWNvbk5hbWUgPSAiZ28tbmV4dC1wYWdlIjsKIAogICAgICAgaWYg KCBpZCA9PSBOZXh0ICkKLSAgICAgICAgaWNvbk5hbWUgPSAiZ28tcHJldmlvdXMiOworICAg ICAgICBpY29uTmFtZSA9ICJnby1wcmV2aW91cy1wYWdlIjsKKworICAgICAgaWYgKCBpZCA9 PSBGaXJzdFBhZ2UgKQorCWljb25OYW1lID0gImdvLWxhc3QtcGFnZSI7CisKKyAgICAgIGlm ICggaWQgPT0gTGFzdFBhZ2UgKQorCWljb25OYW1lID0gImdvLWZpcnN0LXBhZ2UiOwogCiAg ICAgICBpZiAoIGlkID09IERvY3VtZW50QmFjayApCi0gICAgICAgIGljb25OYW1lID0gImdv LW5leHQiOworICAgICAgICBpY29uTmFtZSA9ICJnby1uZXh0LWRvY3VtZW50IjsKIAogICAg ICAgaWYgKCBpZCA9PSBEb2N1bWVudEZvcndhcmQgKQotICAgICAgICBpY29uTmFtZSA9ICJn by1wcmV2aW91cyI7CisgICAgICAgIGljb25OYW1lID0gImdvLXByZXZpb3VzLWRvY3VtZW50 IjsKICAgICB9CiAKICAgICBRSWNvbiBpY29uID0gaWNvbk5hbWUuaXNFbXB0eSgpID8gS0lj b24oKSA6IEtJY29uKGljb25OYW1lKTsKSW5kZXg6IGtkZXVpL2FjdGlvbnMva3N0YW5kYXJk YWN0aW9uX3AuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBrZGV1aS9hY3Rpb25zL2tzdGFuZGFyZGFj dGlvbl9wLmgJKHJldmlzaW9uIDgyMzc3MikKKysrIGtkZXVpL2FjdGlvbnMva3N0YW5kYXJk YWN0aW9uX3AuaAkod29ya2luZyBjb3B5KQpAQCAtODAsMTUgKzgwLDE1IEBAIHN0YXRpYyBj b25zdCBLU3RhbmRhcmRBY3Rpb25JbmZvIGdfcmdBY3QKICAgeyBCYWNrLCAgICAgICAgICBL U3RhbmRhcmRTaG9ydGN1dDo6QmFjaywgImdvX2JhY2siLCAwLCAwLCAiZ28tcHJldmlvdXMi IH0sCiAgIHsgRm9yd2FyZCwgICAgICAgS1N0YW5kYXJkU2hvcnRjdXQ6OkZvcndhcmQsICJn b19mb3J3YXJkIiwgMCwgMCwgImdvLW5leHQiIH0sCiAgIHsgSG9tZSwgICAgICAgICAgS1N0 YW5kYXJkU2hvcnRjdXQ6OkhvbWUsICJnb19ob21lIiwgMCwgMCwgImdvLWhvbWUiIH0sCi0g IHsgUHJpb3IsICAgICAgICAgS1N0YW5kYXJkU2hvcnRjdXQ6OlByaW9yLCAiZ29fcHJldmlv dXMiLCBJMThOX05PT1AoIiZQcmV2aW91cyBQYWdlIiksIDAsICJnby1wcmV2aW91cyIgfSwK LSAgeyBOZXh0LCAgICAgICAgICBLU3RhbmRhcmRTaG9ydGN1dDo6TmV4dCwgImdvX25leHQi LCBJMThOX05PT1AoIiZOZXh0IFBhZ2UiKSwgMCwgImdvLW5leHQiIH0sCisgIHsgUHJpb3Is ICAgICAgICAgS1N0YW5kYXJkU2hvcnRjdXQ6OlByaW9yLCAiZ29fcHJldmlvdXMiLCBJMThO X05PT1AoIiZQcmV2aW91cyBQYWdlIiksIDAsICJnby1wcmV2aW91cy1wYWdlIiB9LAorICB7 IE5leHQsICAgICAgICAgIEtTdGFuZGFyZFNob3J0Y3V0OjpOZXh0LCAiZ29fbmV4dCIsIEkx OE5fTk9PUCgiJk5leHQgUGFnZSIpLCAwLCAiZ28tbmV4dC1wYWdlIiB9LAogICB7IEdvdG8s ICAgICAgICAgIEtTdGFuZGFyZFNob3J0Y3V0OjpBY2NlbE5vbmUsICJnb19nb3RvIiwgSTE4 Tl9OT09QKCImR28gVG8uLi4iKSwgMCwgMCB9LAogICB7IEdvdG9QYWdlLCAgICAgIEtTdGFu ZGFyZFNob3J0Y3V0OjpBY2NlbE5vbmUsICJnb19nb3RvX3BhZ2UiLCBJMThOX05PT1AoIiZH byB0byBQYWdlLi4uIiksIDAsICJnby1qdW1wIiB9LAogICB7IEdvdG9MaW5lLCAgICAgIEtT dGFuZGFyZFNob3J0Y3V0OjpHb3RvTGluZSwgImdvX2dvdG9fbGluZSIsIEkxOE5fTk9PUCgi JkdvIHRvIExpbmUuLi4iKSwgMCwgMCB9LAotICB7IEZpcnN0UGFnZSwgICAgIEtTdGFuZGFy ZFNob3J0Y3V0OjpCZWdpbiwgImdvX2ZpcnN0IiwgSTE4Tl9OT09QKCImRmlyc3QgUGFnZSIp LCAwLCAiZ28tZmlyc3QiIH0sCi0gIHsgTGFzdFBhZ2UsICAgICAgS1N0YW5kYXJkU2hvcnRj dXQ6OkVuZCwgImdvX2xhc3QiLCBJMThOX05PT1AoIiZMYXN0IFBhZ2UiKSwgMCwgImdvLWxh c3QiIH0sCi0gIHsgRG9jdW1lbnRCYWNrLCAgS1N0YW5kYXJkU2hvcnRjdXQ6OkFjY2VsTm9u ZSwgImdvX2RvY3VtZW50X2JhY2siLCBJMThOX05PT1AoIiZCYWNrIGluIHRoZSBEb2N1bWVu dCIpLCAwLCAiZ28tcHJldmlvdXMiIH0sCi0gIHsgRG9jdW1lbnRGb3J3YXJkLCBLU3RhbmRh cmRTaG9ydGN1dDo6QWNjZWxOb25lLCAiZ29fZG9jdW1lbnRfZm9yd2FyZCIsIEkxOE5fTk9P UCgiJkZvcndhcmQgaW4gdGhlIERvY3VtZW50IiksIDAsICJnby1uZXh0IiB9LAorICB7IEZp cnN0UGFnZSwgICAgIEtTdGFuZGFyZFNob3J0Y3V0OjpCZWdpbiwgImdvX2ZpcnN0IiwgSTE4 Tl9OT09QKCImRmlyc3QgUGFnZSIpLCAwLCAiZ28tZmlyc3QtcGFnZSIgfSwKKyAgeyBMYXN0 UGFnZSwgICAgICBLU3RhbmRhcmRTaG9ydGN1dDo6RW5kLCAiZ29fbGFzdCIsIEkxOE5fTk9P UCgiJkxhc3QgUGFnZSIpLCAwLCAiZ28tbGFzdC1wYWdlIiB9LAorICB7IERvY3VtZW50QmFj aywgIEtTdGFuZGFyZFNob3J0Y3V0OjpBY2NlbE5vbmUsICJnb19kb2N1bWVudF9iYWNrIiwg STE4Tl9OT09QKCImQmFjayBpbiB0aGUgRG9jdW1lbnQiKSwgMCwgImdvLXByZXZpb3VzLWRv Y3VtZW50IiB9LAorICB7IERvY3VtZW50Rm9yd2FyZCwgS1N0YW5kYXJkU2hvcnRjdXQ6OkFj Y2VsTm9uZSwgImdvX2RvY3VtZW50X2ZvcndhcmQiLCBJMThOX05PT1AoIiZGb3J3YXJkIGlu IHRoZSBEb2N1bWVudCIpLCAwLCAiZ28tbmV4dC1kb2N1bWVudCIgfSwKIAogICB7IEFkZEJv b2ttYXJrLCAgIEtTdGFuZGFyZFNob3J0Y3V0OjpBZGRCb29rbWFyaywgImJvb2ttYXJrX2Fk ZCIsIEkxOE5fTk9PUCgiJkFkZCBCb29rbWFyayIpLCAwLCAiYm9va21hcmstbmV3IiB9LAog ICB7IEVkaXRCb29rbWFya3MsIEtTdGFuZGFyZFNob3J0Y3V0OjpBY2NlbE5vbmUsICJib29r bWFya19lZGl0IiwgSTE4Tl9OT09QKCImRWRpdCBCb29rbWFya3MiKSwgMCwgImJvb2ttYXJr cyIgfSwK --------------080804000107050809020505--