[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    KDE/kdelibs/kio
From:       David Faure <faure () kde ! org>
Date:       2006-10-09 16:20:52
Message-ID: 1160410852.185751.1077.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 593946 by dfaure:

Refactored KFileItem to use QSharedDataPointer - which means that it's now allowed
to use KFileItem as a value, copying it is cheap, since it's now implicitly shared.
All the current code uses it as a pointer, which is still fine of course, but using it
as a value in the future can simplify things like PreviewJob, which used to crash
due to sometimes keeping a pointer to a deleted kfileitem.
Refcounting KFileItems is what Waldo has been advocating for a very long time btw,
I'm glad to honor his wish after so many years :)
Michael, this is also something to keep in mind if/when rewriting KDirLister.

CCMAIL: kde-core-devel@kde.org


 M  +856 -664  kio/kfileitem.cpp  
 M  +441 -510  kio/kfileitem.h  
 M  +73 -0     tests/kfileitemtest.cpp  
 M  +4 -0      tests/kfileitemtest.h  


[prev in list] [next in list] [prev in thread] [next in thread]