From kde-core-devel Mon Oct 09 16:20:52 2006 From: David Faure Date: Mon, 09 Oct 2006 16:20:52 +0000 To: kde-core-devel Subject: KDE/kdelibs/kio Message-Id: <1160410852.185751.1077.nullmailer () svn ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=116041091905276 SVN commit 593946 by dfaure: Refactored KFileItem to use QSharedDataPointer - which means that it's now allowed to use KFileItem as a value, copying it is cheap, since it's now implicitly shared. All the current code uses it as a pointer, which is still fine of course, but using it as a value in the future can simplify things like PreviewJob, which used to crash due to sometimes keeping a pointer to a deleted kfileitem. Refcounting KFileItems is what Waldo has been advocating for a very long time btw, I'm glad to honor his wish after so many years :) Michael, this is also something to keep in mind if/when rewriting KDirLister. CCMAIL: kde-core-devel@kde.org M +856 -664 kio/kfileitem.cpp M +441 -510 kio/kfileitem.h M +73 -0 tests/kfileitemtest.cpp M +4 -0 tests/kfileitemtest.h