[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: 3.5.5: please review nasty API change in wireless extensions
From:       Thiago Macieira <thiago () kde ! org>
Date:       2006-09-28 17:42:23
Message-ID: 200609281942.23581.thiago () kde ! org
[Download RAW message or body]


Stefan Winter wrote:
>-  wrq.u.essid.pointer = (caddr_t) WIFI_CONFIG(info,essid);
>+  /* prepare NULL-terminated buffer in case the string returned by
>SIOCGIWESSID is NOT NULL-terminated */
>+  memset(wrq.u.essid.pointer, '\0', IW_ESSID_MAX_SIZE + 1);

Looks sane, but is wrq.u.essid.pointer always guaranteed to be 
IW_ESSID_MAX_SIZE + 1 or more?

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]