From kde-core-devel Thu Sep 28 17:42:23 2006 From: Thiago Macieira Date: Thu, 28 Sep 2006 17:42:23 +0000 To: kde-core-devel Subject: Re: 3.5.5: please review nasty API change in wireless extensions Message-Id: <200609281942.23581.thiago () kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=115946538217677 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart1900777.nBJjJiB0yF" --nextPart1900777.nBJjJiB0yF Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Stefan Winter wrote: >- =A0wrq.u.essid.pointer =3D (caddr_t) WIFI_CONFIG(info,essid); >+ =A0/* prepare NULL-terminated buffer in case the string returned by >SIOCGIWESSID is NOT NULL-terminated */ >+ =A0memset(wrq.u.essid.pointer, '\0', IW_ESSID_MAX_SIZE + 1); Looks sane, but is wrq.u.essid.pointer always guaranteed to be=20 IW_ESSID_MAX_SIZE + 1 or more? =2D-=20 =A0 Thiago Macieira =A0- =A0thiago (AT) macieira.info - thiago (AT) kde.org =A0 =A0 PGP/GPG: 0x6EF45358; fingerprint: =A0 =A0 E067 918B B660 DBD1 105C =A0966C 33F5 F005 6EF4 5358 --nextPart1900777.nBJjJiB0yF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBFHAl/M/XwBW70U1gRArgzAJoDPqpmvNVlKZzdQhtaOmX2TxuJ1QCdEox/ 7XQZoCecgxapMarxTsmBlfU= =8itb -----END PGP SIGNATURE----- --nextPart1900777.nBJjJiB0yF--