[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Valgrind hit in kio_data [PATCH]
From:       Waldo Bastian <bastian () kde ! org>
Date:       2005-02-25 9:18:56
Message-ID: 200502251018.59807.bastian () kde ! org
[Download RAW message or body]


On Friday 25 February 2005 00:05, David Faure wrote:
> Obviously the slave is emitting finished() immediately, so the next line
> after SimpleJob::start() in TransferJob::start() is reading a member var
> with "this" being deleted already.
>
> No other slave emits finished() from inside start(). So I fixed kio_data
> for delay the emission of finished() in all cases (not just when suspended,
> like the code said).

Should be the proper fix indeed.

Cheers,
Waldo
-- 
bastian@kde.org   |   Free Novell Linux Desktop 9 Evaluation Download
bastian@suse.com  |   http://www.novell.com/products/desktop/eval.html

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]