From kde-core-devel Fri Feb 25 09:18:56 2005 From: Waldo Bastian Date: Fri, 25 Feb 2005 09:18:56 +0000 To: kde-core-devel Subject: Re: Valgrind hit in kio_data [PATCH] Message-Id: <200502251018.59807.bastian () kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=110932315612343 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart1373450.UUsLXnNbGm" --nextPart1373450.UUsLXnNbGm Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 25 February 2005 00:05, David Faure wrote: > Obviously the slave is emitting finished() immediately, so the next line > after SimpleJob::start() in TransferJob::start() is reading a member var > with "this" being deleted already. > > No other slave emits finished() from inside start(). So I fixed kio_data > for delay the emission of finished() in all cases (not just when suspende= d, > like the code said). Should be the proper fix indeed. Cheers, Waldo =2D-=20 bastian@kde.org | Free Novell Linux Desktop 9 Evaluation Download bastian@suse.com | http://www.novell.com/products/desktop/eval.html --nextPart1373450.UUsLXnNbGm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQBCHu2DN4pvrENfboIRAtvQAKCM0GUOqeqnM/i2yPtCbrCKuQghdgCfYV6d 0kn3bUAby4rpsaHxaIs9S7w= =rq0y -----END PGP SIGNATURE----- --nextPart1373450.UUsLXnNbGm--