[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Encoding box in the file dialog
From:       Andras Mantia <amantia () kde ! org>
Date:       2003-09-21 18:21:04
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 21 September 2003 16:50, Simon Hausmann wrote:
> On Sun, Sep 21, 2003 at 04:34:38PM +0300, Andras Mantia wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > Hi,
> > 
> >   Here is the implementation of what I've talked about some days ago: 
mergin 
> > the Kate::FileDialog into KFileDialog. KFileDialog now has a new ctor for 
> > text files which provides an encoding combo. 
> >  Please review, and if there are no issues with it, I will commit, as we 
> > basicly agreed with the parties involved. The users of Kate::FileDialog 
will 
> > need to modify their code a little, as the parameters for the new ctor are 
> > not in the same order and the encoding setting must be queried with 
> > selectedEncoding() as it's not provided as the result of exec().
> 
> Just a tiny thought on the patch: Wouldn't it be nicer if the
> default argument for the encoding would be QString::null, documented
> as defaulting to KGlobal::locale()->encoding() (in the .cpp then) ,
> to avoid the two #include statements in the header file?
Yes, you're right. It's better to do that way.

Andras

> 
> Simon
> 
> 

- -- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/bewUTQdfac6L/08RAtulAKCXtxqZHuuxqqd0IJzO843IHh4TyQCfYAKW
gHCzja/XxKGiRZRRg9wY3L8=
=hDmH
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]