[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Encoding box in the file dialog
From:       Carsten Pfeiffer <carpdjih () cetus ! zrz ! tu-berlin ! de>
Date:       2003-09-23 12:10:19
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----

On Sunday 21 September 2003 15:34, Andras Mantia wrote:

Hi,

>   Here is the implementation of what I've talked about some days ago:
> mergin the Kate::FileDialog into KFileDialog. KFileDialog now has a new
> ctor for text files which provides an encoding combo.
>  Please review, and if there are no issues with it, I will commit, as we
> basicly agreed with the parties involved. The users of Kate::FileDialog
> will need to modify their code a little, as the parameters for the new ctor
> are not in the same order and the encoding setting must be queried with
> selectedEncoding() as it's not provided as the result of exec().

just one comment: wouldn't it be sufficient to have that functionality in a 
subclass, like KTextFileDialog, maybe also in kfile?

I mean, kfiledialog.cpp has already way over 2000 lines and while the 
encoding-functionality is important for several editing applications, it is 
not really coupled to the filedialog that every application uses.

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBP3A4LKWgYMJuwmZtAQHKxgf/cYUP62tNdQHVc6iLIf9zDMKXR/3o/C0L
GMrR2FdiluPjzf9uqlji7bFfPjd4Nitticac3kI16624D94BQY/mCCR3FKTPS0+i
a6/2oKOPwMmIALwZHP6UDl1xt9Obmm1EVEZwN545rSxtLWVGjIOKbs1TY4V/dmzt
PdKx8vRD/l061vDX+tPC3WlT3MxxOF7Nf96ClKRZSapspy3B0/9f0z9cc7GZ0y2V
rW9FaHI02sFX3OahLD9iRLSkU7tkU8r8Z6weD8XE6TqlRzKQf2BGCvduAu6ZytVk
9dNYZMJ6OSDXO3vVIYKC29JPDjE3MMa3MZC3htvWy5gVTP6MbV6zuA==
=5JV4
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]