[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Encoding box in the file dialog
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2003-09-21 13:50:39
[Download RAW message or body]

On Sun, Sep 21, 2003 at 04:34:38PM +0300, Andras Mantia wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
>   Here is the implementation of what I've talked about some days ago: mergin 
> the Kate::FileDialog into KFileDialog. KFileDialog now has a new ctor for 
> text files which provides an encoding combo. 
>  Please review, and if there are no issues with it, I will commit, as we 
> basicly agreed with the parties involved. The users of Kate::FileDialog will 
> need to modify their code a little, as the parameters for the new ctor are 
> not in the same order and the encoding setting must be queried with 
> selectedEncoding() as it's not provided as the result of exec().

Just a tiny thought on the patch: Wouldn't it be nicer if the
default argument for the encoding would be QString::null, documented
as defaulting to KGlobal::locale()->encoding() (in the .cpp then) ,
to avoid the two #include statements in the header file?

Simon
[prev in list] [next in list] [prev in thread] [next in thread]