[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: patch: kfind #39655
From:       Thomas Zander <zander () planescape ! com>
Date:       2002-03-30 15:44:42
[Download RAW message or body]


On Sat, Mar 30, 2002 at 04:08:03PM +0100, Daniel Naber wrote:
> On Saturday 30 March 2002 15:32, Thomas Zander wrote:
> 
> > That is wrong since the original string is a '*', so if the users
> > removed that he certainly did not mean to find everything.
> 
> "*" works together with the other options, i.e. it will only find 
> everything if there's no other option set (logical 'and'). So if someone 
> removes the name completely, what does he want? Of course it means that 
> the name is not relevant to him, which is the same as "*".
> 

Hmm, ok. Since the tabs all together form the query it starts to make more
sense.
I believe there should be some minor changes in the layout to make obvious 
the fact that it behaves differently from the windows/mac version of the
same app.

> > The correct patch would just disable the 'Find' button when no string is
> > entered.
> 
> I don't like this "disable buttons" approach. There are three tabs and 
> many, many options. How should the user know which option he has to set so 
> the button is enabled again? Disabling buttons decreases usability except 
> for trivial cases (e.g. one line edit + "OK" button).

Ok, you are right, this is the correct patch. Please commit.

-- 
Thomas Zander                                            zander@earthling.net
The only thing worse than failure is the fear of trying something new

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]