From kde-core-devel  Sat Mar 30 15:44:42 2002
From: Thomas Zander <zander () planescape ! com>
Date: Sat, 30 Mar 2002 15:44:42 +0000
To: kde-core-devel
Subject: Re: patch: kfind #39655
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=101750348522507
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--tjCHc7DPkfUGtrlw"


--tjCHc7DPkfUGtrlw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 30, 2002 at 04:08:03PM +0100, Daniel Naber wrote:
> On Saturday 30 March 2002 15:32, Thomas Zander wrote:
>=20
> > That is wrong since the original string is a '*', so if the users
> > removed that he certainly did not mean to find everything.
>=20
> "*" works together with the other options, i.e. it will only find=20
> everything if there's no other option set (logical 'and'). So if someone=
=20
> removes the name completely, what does he want? Of course it means that=
=20
> the name is not relevant to him, which is the same as "*".
>=20

Hmm, ok. Since the tabs all together form the query it starts to make more
sense.
I believe there should be some minor changes in the layout to make obvious=
=20
the fact that it behaves differently from the windows/mac version of the
same app.

> > The correct patch would just disable the 'Find' button when no string is
> > entered.
>=20
> I don't like this "disable buttons" approach. There are three tabs and=20
> many, many options. How should the user know which option he has to set s=
o=20
> the button is enabled again? Disabling buttons decreases usability except=
=20
> for trivial cases (e.g. one line edit + "OK" button).

Ok, you are right, this is the correct patch. Please commit.

--=20
Thomas Zander                                            zander@earthling.n=
et
The only thing worse than failure is the fear of trying something new

--tjCHc7DPkfUGtrlw
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8pd1qCojCW6H2z/QRAvDUAKDYjz06qtH6KpBnCQcq93wz+Y4BIACffVIC
awLI8mE8FMnAlcElXDUz9+o=
=xadZ
-----END PGP SIGNATURE-----

--tjCHc7DPkfUGtrlw--