[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KConfigBackend
From:       Waldo Bastian <bastian () kde ! org>
Date:       2002-02-23 18:45:32
[Download RAW message or body]

On Saturday 23 February 2002 02:53 am, ossi@mail.kde.org wrote:
> On Fri, Feb 22, 2002 at 05:52:59PM -0800, Waldo Bastian wrote:
> > The following patch implements some missing features for KConfig.
>
> i don't like it too much. i'm currently re-working it.
> anyway, 

I would prefer it if you just told me what functionality you want.

> i have two questions:
> a) could you please exactly explain the wanted semantics of the used
>   file mode and whether the file is re-created? your patch contains
>   a lot of cases and i'm not sure which ones are intented.

The file is recreated unless
* It is a symlink that isn't stale
* The file is not owned by you

> b) i don't like the ksavefile vs. fopen code. i'm in favour of moving this
>   whole discrimination to ksavefile (and obviously adding some more options
>   to it).

That breaks the semantics of KSaveFile. In order for abort to work you must 
create a new file.

> also, i'm going to introduce a flag to override the file mode even if the
> file already exists (i.e., restore current behaviour).

I can add a bool for that to setFileWriteMode, but like I said before you can 
also just call chmod yourself. Or I can reverse the preference and always use 
the specified mode (if one was explicitly specified) instead of the existing 
mode. I actually had that originally but changed that to the current 
behaviour.

> my real point is, that the conversion
> functions can be reused outside kconfig (i need this in kdm).

Just subclass kconfigbase, It's done in two places in kio.

Cheers,
Waldo
-- 
Advanced technology only happens when people take a basic idea and add to it.
 -- Bob Bemer

[prev in list] [next in list] [prev in thread] [next in thread]