[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH]: am_edit vs. uic images
From:       Werner Trobin <trobin () kde ! org>
Date:       2002-02-22 18:15:47
[Download RAW message or body]

On Friday 22 February 2002 19:06, Michael Matz wrote:
> Hi,
>
> On Fri, 22 Feb 2002, Werner Trobin wrote:
> > As the designer always generates the same names for embedded images in
> > .ui files (image0, image1,...) --enable-final breaks as multiple arrays
> > in the huge .all_cpp.cpp file are called the same way.
> >
> > The attached patch simply prefixes those image names with the filename.
> >
> > Comments? Suggestions?
>
> Too simple.  Think filenames with '-' in them, would result in invalid
> identifiers.  I suggest preparing $source by something like (the
> untested):
> my ($mangled_source = $source) =~ s/[^A-Za-z0-9_]/_/g;
>
> and using $mangled_source then.

Ahh, right.

Another question to you: Are there compilers out there which would have 
problems with too long symbol names? I somewhere read that symbol names have 
to be distinguishable (haha! I created a new word!) after 32 characters or 
so.

The "fix" would be to use something like imgXX<modified_filename> where XX is 
the number.

Ciao,
Werner
[prev in list] [next in list] [prev in thread] [next in thread]