[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] ksmserver: take two
From:       Matthias Ettrich <ettrich () trolltech ! com>
Date:       2002-01-31 12:23:37
[Download RAW message or body]

On Wednesday 30 January 2002 23:00, ossi@master.kde.org wrote:
> this patch is based on the part of Martijn's patch i didn't commit yet.
> the gui part is trivial.
>
> i also did some changes i consider a cleanup. however, i'm concerned about
> removing the keyEvent and mouseEvent handlers: theoretically they are not
> necessary, but i'm not sure why they were introduced in the first place -
> but in the testsh it _seems_ to behave correctly.
> dfaure: you introduced the keyevent handler - what was the idea behind it?
>  qdialog handles escape for us, doesn't it?
> mettrich: why do you swallow all mouse press events? the qwidget that
>  covers the whole desktop won't allow them to do any harm anyway, or?

Probably not. The dummy handler doesn't seem to make sense, I agree.

Matthias

[prev in list] [next in list] [prev in thread] [next in thread]