[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] ksmserver: take two
From:       Martijn Klingens <mklingens () yahoo ! com>
Date:       2002-01-30 22:47:28
[Download RAW message or body]

On Wednesday 30 January 2002 23:00, ossi@master.kde.org wrote:
> this patch is based on the part of Martijn's patch i didn't commit yet.
> the gui part is trivial.

Yes, and it looks good to me. Can't comment on the rest. One notice, though: 
you changed an i18n() call by removing the rich text tags. I'm not sure if 
that's still acceptible now...

> i also did some changes i consider a cleanup. however, i'm concerned about
> removing the keyEvent and mouseEvent handlers: theoretically they are not
> necessary, but i'm not sure why they were introduced in the first place -
> but in the testsh it _seems_ to behave correctly.
> dfaure: you introduced the keyevent handler - what was the idea behind it?
>  qdialog handles escape for us, doesn't it?
> mettrich: why do you swallow all mouse press events? the qwidget that
>  covers the whole desktop won't allow them to do any harm anyway, or?

I asked you in private mail today and as you don't know, maybe one of the 
others know: the "qwidget that covers the whole desktop" is broken here for 
me for a very long time. It also is at work, but both boxes are almost 
identically configured, so it can be a problem of my part.

The widget is drawn, but as soon as the logout dialog is shown the widget is 
hidden again and the whole desktop is accessible. I can give windows focus, 
keep on working, etc. Only the logout dialog is on top of that, of course.

Any ideas what's wrong? Or do more people have this and is this a bug?

Martijn
[prev in list] [next in list] [prev in thread] [next in thread]