[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] startkde and ksmserver
From:       Olivier Chapuis <olivier.chapuis () free ! fr>
Date:       2001-10-06 14:24:59
[Download RAW message or body]

On Sat, Oct 06, 2001 at 12:04:19PM +0200, Oswald Buddenhagen wrote:
> >   --norestore                 Does not restore the session
> >
> also consider interpreting an environment variable "XSM_RESTORE"
> assuming a default of "true/yes". i plan something like that for kdm
> integration. however, i can still add it later.
>
 
Good idea. Just before "ksmserver ... ":
                                        
    # handle the XSM_RESTORE env variable (override --norestore)
    if test "x$XSM_RESTORE" = "xtrue" -o "x$XSM_RESTORE" = "xyes"; then
     restore="--restore"                                               
    elif test "x$XSM_RESTORE" = "xfalse" -o "x$XSM_RESTORE" = "xno"; then
     restore=""                                                          
    fi         

> >   --nolocal                   Also allow remote connections
> >
> that's not a good name. it sounds like you are wanting to forbid local
> connections ...
> use --allow-remote (alternative -r) for it.
>
 
The name "--nolocal" is the corresponding ksmserver option.
I am agree that it is not good. However, one may think that
the options should match as possible the ksmserver one's.
So, maybe the ksmserver option name should be changed too
(with backward comp)?

Do you want I re-send the patches with the changes? It is not
a problem, but maybe if someone applies the patches (s)he can
take a decision (and do the appropriate changes).

Regards, Olivier

PS: Oswald, I cc to you because my mail may take some times
to come up on kde-core-devel.

[prev in list] [next in list] [prev in thread] [next in thread]