[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] startkde and ksmserver
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2001-10-06 14:48:30
[Download RAW message or body]

> Good idea. Just before "ksmserver ... ":
>                                         
>     # handle the XSM_RESTORE env variable (override --norestore)
>     if test "x$XSM_RESTORE" = "xtrue" -o "x$XSM_RESTORE" = "xyes"; then
>      restore="--restore"                                               
>     elif test "x$XSM_RESTORE" = "xfalse" -o "x$XSM_RESTORE" = "xno"; then
>      restore=""                                                          
>     fi         
> 
better don't use -o. use test || test instead.
otoh, forget the "or". let's agree on true/false.
ah, unset XSM_RESTORE after testing it. no need to pollute the
environment further. also, do it right after parsing the options, so
no program will inherit it.

> The name "--nolocal" is the corresponding ksmserver option.
>
whoops ...

> So, maybe the ksmserver option name should be changed too
> (with backward comp)?
> 
mr. ettrich? should we? :)

greetings

ps: olivier, your Mail-Followup-To: headers contain a messed up address
(olivier@snoopy.parislyon) ...

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Nothing is fool-proof to a sufficiently talented fool.

[prev in list] [next in list] [prev in thread] [next in thread]