[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdelibs/KDE/4.8] kio/kio: dataprotocol: cleanup parsing of URL
From:       Leo Savernik <l.savernik () aon ! at>
Date:       2012-05-16 13:38:39
Message-ID: 201205161538.39964.l.savernik () aon ! at
[Download RAW message or body]

Am Sonntag, 6. Mai 2012 schrieb Rolf Eike Beer:
> - * @param header_info fills the given DataHeader structure with the header
> - *             information
> + * @param mimeOnly if the only interesting information is the mime type
> + * @return DataHeader structure with the header information
>   */
> -static void parseDataHeader(const KUrl &url, DataHeader &header_info) {
> +static DataHeader parseDataHeader(const KUrl &url, const bool mimeOnly)
> +{

You're now making a deep copy instead of filling a preallocated structure. Is 
this intended?

mfg
	Leo

[prev in list] [next in list] [prev in thread] [next in thread]