[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdelibs/KDE/4.8] kio/kio: dataprotocol: cleanup parsing of URL
From:       Rolf Eike Beer <kde () opensource ! sf-tec ! de>
Date:       2012-05-16 15:12:05
Message-ID: 7398588.G8RrZeoNGf () donald ! sf-tec ! de
[Download RAW message or body]


Am Mittwoch, 16. Mai 2012, 15:38:39 schrieben Sie:
> Am Sonntag, 6. Mai 2012 schrieb Rolf Eike Beer:
> > - * @param header_info fills the given DataHeader structure with the
> > header
> > - *             information
> > + * @param mimeOnly if the only interesting information is the mime type
> > + * @return DataHeader structure with the header information
> > 
> >   */
> > 
> > -static void parseDataHeader(const KUrl &url, DataHeader &header_info) {
> > +static DataHeader parseDataHeader(const KUrl &url, const bool mimeOnly)
> > +{
> 
> You're now making a deep copy instead of filling a preallocated structure.
> Is this intended?

Yes, because everything in there is either trivial or implicitely shared 
anyway. And compilers are clever things ;)

Eike
["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]