From kde-commits Wed May 16 13:38:39 2012 From: Leo Savernik Date: Wed, 16 May 2012 13:38:39 +0000 To: kde-commits Subject: Re: [kdelibs/KDE/4.8] kio/kio: dataprotocol: cleanup parsing of URL Message-Id: <201205161538.39964.l.savernik () aon ! at> X-MARC-Message: https://marc.info/?l=kde-commits&m=133717565822399 Am Sonntag, 6. Mai 2012 schrieb Rolf Eike Beer: > - * @param header_info fills the given DataHeader structure with the header > - * information > + * @param mimeOnly if the only interesting information is the mime type > + * @return DataHeader structure with the header information > */ > -static void parseDataHeader(const KUrl &url, DataHeader &header_info) { > +static DataHeader parseDataHeader(const KUrl &url, const bool mimeOnly) > +{ You're now making a deep copy instead of filling a preallocated structure. Is this intended? mfg Leo