[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdecore/sonnet
From:       Zack Rusin <zack () kde ! org>
Date:       2009-11-30 23:21:06
Message-ID: 200911301821.06757.zack () kde ! org
[Download RAW message or body]

On Monday 30 November 2009 17:53:12 David Faure wrote:
> On Monday 30 November 2009, Zack Rusin wrote:
> > SVN commit 1056377 by zack:
> >
> > sonnet: rewrite text segmentation algorithm
> >
> > since its creation sonnet was broken with indic, asian, arabic and
> > a lot of other languages that didn't use english-like alphabets.
> > this commit removes the custom text segmentation algorithm and replaces
> > it with a proper unicode tr29-11 algorithm found in qtextboundaryfinder
> > and hopefully makes sonnet work with all languages in the world. let me
> >  know if causes any regressions.
> 
> Well, that's what unittests are for ;-)

Yea, it's why I added some when committing this unfortunately it's a bit hard 
to cover peculiarities of every language out there =)

> It seems your changes introduce a regression, because
>  sonnet/tests/test_core uses 100% CPU for a very very long time and never
>  terminates.

Hmm, it works here. That test always took a bit of time. I just committed a 
trivial fixlet that should improve it though, does it make it better for you?

z
[prev in list] [next in list] [prev in thread] [next in thread]