[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdecore/sonnet
From:       David Faure <faure () kde ! org>
Date:       2009-11-30 22:53:12
Message-ID: 200911302353.12996.faure () kde ! org
[Download RAW message or body]

On Monday 30 November 2009, Zack Rusin wrote:
> SVN commit 1056377 by zack:
> 
> sonnet: rewrite text segmentation algorithm
> 
> since its creation sonnet was broken with indic, asian, arabic and
> a lot of other languages that didn't use english-like alphabets.
> this commit removes the custom text segmentation algorithm and replaces
> it with a proper unicode tr29-11 algorithm found in qtextboundaryfinder
> and hopefully makes sonnet work with all languages in the world. let me
>  know if causes any regressions.

Well, that's what unittests are for ;-)

It seems your changes introduce a regression, because sonnet/tests/test_core
uses 100% CPU for a very very long time and never terminates.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
[prev in list] [next in list] [prev in thread] [next in thread]